andreas/llama-swap
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix some potentially confusing Process.start() comment

Browse Source
This commit is contained in:
Benson Wong
2025-03-11 11:00:45 -07:00
parent 9b2ed244e2
commit 60355bf74a
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
proxy/process.go
View File

@@ -116,7 +116,9 @@ func (p *Process) start() error {
return fmt.Errorf("can not start(), upstream proxy missing") return fmt.Errorf("can not start(), upstream proxy missing")
} }
// wait for the other start() to complete // multiple start() calls will wait for the one that is actually starting to
// complete before proceeding.
// ===========
curState := p.CurrentState() curState := p.CurrentState()
if curState == StateReady { if curState == StateReady {
@@ -132,6 +134,7 @@ func (p *Process) start() error {
return nil return nil
} }
// ===========
// There is the possibility of a hard to replicate race condition where // There is the possibility of a hard to replicate race condition where
// curState *WAS* StateStopped but by the time we get to the p.stateMutex.Lock() // curState *WAS* StateStopped but by the time we get to the p.stateMutex.Lock()