From c3b4bb1684a3dccd58563a84e5e535918c4414e4 Mon Sep 17 00:00:00 2001 From: Benson Wong Date: Mon, 18 Nov 2024 15:30:16 -0800 Subject: [PATCH] use gin for http server --- go.mod | 26 +++++++++ go.sum | 73 +++++++++++++++++++++++ llama-swap.go | 2 +- proxy/manager.go | 147 +++++++++++++++++++++++++++++++++-------------- 4 files changed, 204 insertions(+), 44 deletions(-) diff --git a/go.mod b/go.mod index 56cd702..7145680 100644 --- a/go.mod +++ b/go.mod @@ -8,6 +8,32 @@ require ( ) require ( + github.com/bytedance/sonic v1.11.6 // indirect + github.com/bytedance/sonic/loader v0.1.1 // indirect + github.com/cloudwego/base64x v0.1.4 // indirect + github.com/cloudwego/iasm v0.2.0 // indirect github.com/davecgh/go-spew v1.1.1 // indirect + github.com/gabriel-vasile/mimetype v1.4.3 // indirect + github.com/gin-contrib/sse v0.1.0 // indirect + github.com/gin-gonic/gin v1.10.0 // indirect + github.com/go-playground/locales v0.14.1 // indirect + github.com/go-playground/universal-translator v0.18.1 // indirect + github.com/go-playground/validator/v10 v10.20.0 // indirect + github.com/goccy/go-json v0.10.2 // indirect + github.com/json-iterator/go v1.1.12 // indirect + github.com/klauspost/cpuid/v2 v2.2.7 // indirect + github.com/leodido/go-urn v1.4.0 // indirect + github.com/mattn/go-isatty v0.0.20 // indirect + github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect + github.com/modern-go/reflect2 v1.0.2 // indirect + github.com/pelletier/go-toml/v2 v2.2.2 // indirect github.com/pmezard/go-difflib v1.0.0 // indirect + github.com/twitchyliquid64/golang-asm v0.15.1 // indirect + github.com/ugorji/go/codec v1.2.12 // indirect + golang.org/x/arch v0.8.0 // indirect + golang.org/x/crypto v0.23.0 // indirect + golang.org/x/net v0.25.0 // indirect + golang.org/x/sys v0.20.0 // indirect + golang.org/x/text v0.15.0 // indirect + google.golang.org/protobuf v1.34.1 // indirect ) diff --git a/go.sum b/go.sum index 60ce688..e8333c3 100644 --- a/go.sum +++ b/go.sum @@ -1,10 +1,83 @@ +github.com/bytedance/sonic v1.11.6 h1:oUp34TzMlL+OY1OUWxHqsdkgC/Zfc85zGqw9siXjrc0= +github.com/bytedance/sonic v1.11.6/go.mod h1:LysEHSvpvDySVdC2f87zGWf6CIKJcAvqab1ZaiQtds4= +github.com/bytedance/sonic/loader v0.1.1 h1:c+e5Pt1k/cy5wMveRDyk2X4B9hF4g7an8N3zCYjJFNM= +github.com/bytedance/sonic/loader v0.1.1/go.mod h1:ncP89zfokxS5LZrJxl5z0UJcsk4M4yY2JpfqGeCtNLU= +github.com/cloudwego/base64x v0.1.4 h1:jwCgWpFanWmN8xoIUHa2rtzmkd5J2plF/dnLS6Xd/0Y= +github.com/cloudwego/base64x v0.1.4/go.mod h1:0zlkT4Wn5C6NdauXdJRhSKRlJvmclQ1hhJgA0rcu/8w= +github.com/cloudwego/iasm v0.2.0 h1:1KNIy1I1H9hNNFEEH3DVnI4UujN+1zjpuk6gwHLTssg= +github.com/cloudwego/iasm v0.2.0/go.mod h1:8rXZaNYT2n95jn+zTI1sDr+IgcD2GVs0nlbbQPiEFhY= +github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c= github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= +github.com/gabriel-vasile/mimetype v1.4.3 h1:in2uUcidCuFcDKtdcBxlR0rJ1+fsokWf+uqxgUFjbI0= +github.com/gabriel-vasile/mimetype v1.4.3/go.mod h1:d8uq/6HKRL6CGdk+aubisF/M5GcPfT7nKyLpA0lbSSk= +github.com/gin-contrib/sse v0.1.0 h1:Y/yl/+YNO8GZSjAhjMsSuLt29uWRFHdHYUb5lYOV9qE= +github.com/gin-contrib/sse v0.1.0/go.mod h1:RHrZQHXnP2xjPF+u1gW/2HnVO7nvIa9PG3Gm+fLHvGI= +github.com/gin-gonic/gin v1.10.0 h1:nTuyha1TYqgedzytsKYqna+DfLos46nTv2ygFy86HFU= +github.com/gin-gonic/gin v1.10.0/go.mod h1:4PMNQiOhvDRa013RKVbsiNwoyezlm2rm0uX/T7kzp5Y= +github.com/go-playground/locales v0.14.1 h1:EWaQ/wswjilfKLTECiXz7Rh+3BjFhfDFKv/oXslEjJA= +github.com/go-playground/locales v0.14.1/go.mod h1:hxrqLVvrK65+Rwrd5Fc6F2O76J/NuW9t0sjnWqG1slY= +github.com/go-playground/universal-translator v0.18.1 h1:Bcnm0ZwsGyWbCzImXv+pAJnYK9S473LQFuzCbDbfSFY= +github.com/go-playground/universal-translator v0.18.1/go.mod h1:xekY+UJKNuX9WP91TpwSH2VMlDf28Uj24BCp08ZFTUY= +github.com/go-playground/validator/v10 v10.20.0 h1:K9ISHbSaI0lyB2eWMPJo+kOS/FBExVwjEviJTixqxL8= +github.com/go-playground/validator/v10 v10.20.0/go.mod h1:dbuPbCMFw/DrkbEynArYaCwl3amGuJotoKCe95atGMM= +github.com/goccy/go-json v0.10.2 h1:CrxCmQqYDkv1z7lO7Wbh2HN93uovUHgrECaO5ZrCXAU= +github.com/goccy/go-json v0.10.2/go.mod h1:6MelG93GURQebXPDq3khkgXZkazVtN9CRI+MGFi0w8I= +github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg= +github.com/json-iterator/go v1.1.12 h1:PV8peI4a0ysnczrg+LtxykD8LfKY9ML6u2jnxaEnrnM= +github.com/json-iterator/go v1.1.12/go.mod h1:e30LSqwooZae/UwlEbR2852Gd8hjQvJoHmT4TnhNGBo= +github.com/klauspost/cpuid/v2 v2.0.9/go.mod h1:FInQzS24/EEf25PyTYn52gqo7WaD8xa0213Md/qVLRg= +github.com/klauspost/cpuid/v2 v2.2.7 h1:ZWSB3igEs+d0qvnxR/ZBzXVmxkgt8DdzP6m9pfuVLDM= +github.com/klauspost/cpuid/v2 v2.2.7/go.mod h1:Lcz8mBdAVJIBVzewtcLocK12l3Y+JytZYpaMropDUws= +github.com/knz/go-libedit v1.10.1/go.mod h1:MZTVkCWyz0oBc7JOWP3wNAzd002ZbM/5hgShxwh4x8M= +github.com/leodido/go-urn v1.4.0 h1:WT9HwE9SGECu3lg4d/dIA+jxlljEa1/ffXKmRjqdmIQ= +github.com/leodido/go-urn v1.4.0/go.mod h1:bvxc+MVxLKB4z00jd1z+Dvzr47oO32F/QSNjSBOlFxI= +github.com/mattn/go-isatty v0.0.20 h1:xfD0iDuEKnDkl03q4limB+vH+GxLEtL/jb4xVJSWWEY= +github.com/mattn/go-isatty v0.0.20/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y= +github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421/go.mod h1:6dJC0mAP4ikYIbvyc7fijjWJddQyLn8Ig3JB5CqoB9Q= +github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd h1:TRLaZ9cD/w8PVh93nsPXa1VrQ6jlwL5oN8l14QlcNfg= +github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd/go.mod h1:6dJC0mAP4ikYIbvyc7fijjWJddQyLn8Ig3JB5CqoB9Q= +github.com/modern-go/reflect2 v1.0.2 h1:xBagoLtFs94CBntxluKeaWgTMpvLxC4ur3nMaC9Gz0M= +github.com/modern-go/reflect2 v1.0.2/go.mod h1:yWuevngMOJpCy52FWWMvUC8ws7m/LJsjYzDa0/r8luk= +github.com/pelletier/go-toml/v2 v2.2.2 h1:aYUidT7k73Pcl9nb2gScu7NSrKCSHIDE89b3+6Wq+LM= +github.com/pelletier/go-toml/v2 v2.2.2/go.mod h1:1t835xjRzz80PqgE6HHgN2JOsmgYu/h4qDAS4n929Rs= github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM= github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= +github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME= +github.com/stretchr/objx v0.4.0/go.mod h1:YvHI0jy2hoMjB+UWwv71VJQ9isScKT/TqJzVSSt89Yw= +github.com/stretchr/objx v0.5.0/go.mod h1:Yh+to48EsGEfYuaHDzXPcE3xhTkx73EhmCGUpEOglKo= +github.com/stretchr/objx v0.5.2/go.mod h1:FRsXN1f5AsAjCGJKqEizvkpNtU+EGNCLh3NxZ/8L+MA= +github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI= +github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg= +github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg= +github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU= +github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4= +github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo= github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg= github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY= +github.com/twitchyliquid64/golang-asm v0.15.1 h1:SU5vSMR7hnwNxj24w34ZyCi/FmDZTkS4MhqMhdFk5YI= +github.com/twitchyliquid64/golang-asm v0.15.1/go.mod h1:a1lVb/DtPvCB8fslRZhAngC2+aY1QWCk3Cedj/Gdt08= +github.com/ugorji/go/codec v1.2.12 h1:9LC83zGrHhuUA9l16C9AHXAqEV/2wBQ4nkvumAE65EE= +github.com/ugorji/go/codec v1.2.12/go.mod h1:UNopzCgEMSXjBc6AOMqYvWC1ktqTAfzJZUZgYf6w6lg= +golang.org/x/arch v0.0.0-20210923205945-b76863e36670/go.mod h1:5om86z9Hs0C8fWVUuoMHwpExlXzs5Tkyp9hOrfG7pp8= +golang.org/x/arch v0.8.0 h1:3wRIsP3pM4yUptoR96otTUOXI367OS0+c9eeRi9doIc= +golang.org/x/arch v0.8.0/go.mod h1:FEVrYAQjsQXMVJ1nsMoVVXPZg6p2JE2mx8psSWTDQys= +golang.org/x/crypto v0.23.0 h1:dIJU/v2J8Mdglj/8rJ6UUOM3Zc9zLZxVZwwxMooUSAI= +golang.org/x/crypto v0.23.0/go.mod h1:CKFgDieR+mRhux2Lsu27y0fO304Db0wZe70UKqHu0v8= +golang.org/x/net v0.25.0 h1:d/OCCoBEUq33pjydKrGQhw7IlUPI2Oylr+8qLx49kac= +golang.org/x/net v0.25.0/go.mod h1:JkAGAh7GEvH74S6FOH42FLoXpXbE/aqXSrIQjXgsiwM= +golang.org/x/sys v0.5.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= +golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= +golang.org/x/sys v0.20.0 h1:Od9JTbYCk261bKm4M/mw7AklTlFYIa0bIp9BgSm1S8Y= +golang.org/x/sys v0.20.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA= +golang.org/x/text v0.15.0 h1:h1V/4gjBv8v9cjcR6+AR5+/cIYK5N/WAgiv4xlsEtAk= +golang.org/x/text v0.15.0/go.mod h1:18ZOQIKpY8NJVqYksKHtTdi31H5itFRjB5/qKTNYzSU= +google.golang.org/protobuf v1.34.1 h1:9ddQBjfCyZPOHPUiPxpYESBLc+T8P3E+Vo4IbKZgFWg= +google.golang.org/protobuf v1.34.1/go.mod h1:c6P6GXX6sHbq/GpV6MGZEdwhWPcYBgnhAHhKbcUYpos= gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM= gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= +gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM= gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA= gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM= +nullprogram.com/x/optparse v1.0.0/go.mod h1:KdyPE+Igbe0jQUrVfMqDMeJQIJZEuyV7pjYmp6pbG50= +rsc.io/pdf v0.1.1/go.mod h1:n8OzWcQ6Sp37PL01nO98y4iUCRdTGarVfzxY20ICaU4= diff --git a/llama-swap.go b/llama-swap.go index a3820fd..1131043 100644 --- a/llama-swap.go +++ b/llama-swap.go @@ -23,7 +23,7 @@ func main() { } proxyManager := proxy.New(config) - http.HandleFunc("/", proxyManager.HandleFunc) + http.HandleFunc("/", proxyManager.HandlerFunc) fmt.Println("llama-swap listening on " + *listenStr) if err := http.ListenAndServe(*listenStr, nil); err != nil { diff --git a/proxy/manager.go b/proxy/manager.go index 4831e1f..1c566f3 100644 --- a/proxy/manager.go +++ b/proxy/manager.go @@ -8,6 +8,8 @@ import ( "net/http" "sync" "time" + + "github.com/gin-gonic/gin" ) type ProxyManager struct { @@ -16,65 +18,84 @@ type ProxyManager struct { config *Config currentProcess *Process logMonitor *LogMonitor + ginEngine *gin.Engine } func New(config *Config) *ProxyManager { - return &ProxyManager{config: config, currentProcess: nil, logMonitor: NewLogMonitor()} + pm := &ProxyManager{ + config: config, + currentProcess: nil, + logMonitor: NewLogMonitor(), + ginEngine: gin.New(), + } + + // Set up routes using the Gin engine + pm.ginEngine.POST("/v1/chat/completions", pm.proxyChatRequestHandler) + pm.ginEngine.GET("/v1/models", pm.listModelsHandler) + pm.ginEngine.GET("/logs", pm.sendLogsHandlers) + pm.ginEngine.GET("/logs/stream", pm.streamLogsHandler) + pm.ginEngine.GET("/logs/streamSSE", pm.streamLogsHandlerSSE) + pm.ginEngine.NoRoute(pm.proxyRequestHandler) + + // Disable console color for testing + gin.DisableConsoleColor() + + return pm } -func (pm *ProxyManager) HandleFunc(w http.ResponseWriter, r *http.Request) { +func (pm *ProxyManager) HandlerFunc(w http.ResponseWriter, r *http.Request) { + pm.ginEngine.ServeHTTP(w, r) +} - // https://github.com/ggerganov/llama.cpp/blob/master/examples/server/README.md#api-endpoints - if r.URL.Path == "/v1/chat/completions" { - // extracts the `model` from json body - pm.proxyChatRequest(w, r) - } else if r.URL.Path == "/v1/models" { - pm.listModels(w, r) - } else if r.URL.Path == "/logs" { - pm.streamLogs(w, r) - } else { - if pm.currentProcess != nil { - pm.currentProcess.ProxyRequest(w, r) - } else { - http.Error(w, "no strategy to handle request", http.StatusBadRequest) - } +func (pm *ProxyManager) sendLogsHandlers(c *gin.Context) { + c.Header("Content-Type", "text/plain") + history := pm.logMonitor.GetHistory() + _, err := c.Writer.Write(history) + if err != nil { + c.AbortWithError(http.StatusInternalServerError, err) + return } } -func (pm *ProxyManager) streamLogs(w http.ResponseWriter, r *http.Request) { - w.Header().Set("Content-Type", "text/plain") - w.Header().Set("Transfer-Encoding", "chunked") - w.Header().Set("X-Content-Type-Options", "nosniff") +func (pm *ProxyManager) streamLogsHandler(c *gin.Context) { + c.Header("Content-Type", "text/plain") + c.Header("Transfer-Encoding", "chunked") + c.Header("X-Content-Type-Options", "nosniff") ch := pm.logMonitor.Subscribe() defer pm.logMonitor.Unsubscribe(ch) - notify := r.Context().Done() - flusher, ok := w.(http.Flusher) + notify := c.Request.Context().Done() + flusher, ok := c.Writer.(http.Flusher) if !ok { - http.Error(w, "Streaming unsupported", http.StatusInternalServerError) + c.AbortWithError(http.StatusInternalServerError, fmt.Errorf("Streaming unsupported")) return } - skipHistory := r.URL.Query().Has("skip") + _, skipHistory := c.GetQuery("no-history") + // Send history first if not skipped + if !skipHistory { - // Send history first history := pm.logMonitor.GetHistory() if len(history) != 0 { - w.Write(history) + _, err := c.Writer.Write(history) + if err != nil { + c.AbortWithError(http.StatusInternalServerError, err) + return + } flusher.Flush() } } - if !r.URL.Query().Has("stream") { - return - } - // Stream new logs for { select { case msg := <-ch: - w.Write(msg) + _, err := c.Writer.Write(msg) + if err != nil { + c.AbortWithError(http.StatusInternalServerError, err) + return + } flusher.Flush() case <-notify: return @@ -82,7 +103,39 @@ func (pm *ProxyManager) streamLogs(w http.ResponseWriter, r *http.Request) { } } -func (pm *ProxyManager) listModels(w http.ResponseWriter, _ *http.Request) { +func (pm *ProxyManager) streamLogsHandlerSSE(c *gin.Context) { + c.Header("Content-Type", "text/event-stream") + c.Header("Cache-Control", "no-cache") + c.Header("Connection", "keep-alive") + c.Header("X-Content-Type-Options", "nosniff") + + ch := pm.logMonitor.Subscribe() + defer pm.logMonitor.Unsubscribe(ch) + + notify := c.Request.Context().Done() + + // Send history first if not skipped + _, skipHistory := c.GetQuery("skip") + if !skipHistory { + history := pm.logMonitor.GetHistory() + if len(history) != 0 { + c.SSEvent("message", string(history)) + c.Writer.Flush() + } + } + + // Stream new logs + for { + select { + case msg := <-ch: + c.SSEvent("message", string(msg)) + c.Writer.Flush() + case <-notify: + return + } + } +} +func (pm *ProxyManager) listModelsHandler(c *gin.Context) { data := []interface{}{} for id := range pm.config.Models { data = append(data, map[string]interface{}{ @@ -94,11 +147,11 @@ func (pm *ProxyManager) listModels(w http.ResponseWriter, _ *http.Request) { } // Set the Content-Type header to application/json - w.Header().Set("Content-Type", "application/json") + c.Header("Content-Type", "application/json") // Encode the data as JSON and write it to the response writer - if err := json.NewEncoder(w).Encode(map[string]interface{}{"data": data}); err != nil { - http.Error(w, "Error encoding JSON", http.StatusInternalServerError) + if err := json.NewEncoder(c.Writer).Encode(map[string]interface{}{"data": data}); err != nil { + c.AbortWithError(http.StatusInternalServerError, fmt.Errorf("Error encoding JSON")) return } } @@ -126,28 +179,36 @@ func (pm *ProxyManager) swapModel(requestedModel string) error { return pm.currentProcess.Start(pm.config.HealthCheckTimeout) } -func (pm *ProxyManager) proxyChatRequest(w http.ResponseWriter, r *http.Request) { - bodyBytes, err := io.ReadAll(r.Body) +func (pm *ProxyManager) proxyChatRequestHandler(c *gin.Context) { + bodyBytes, err := io.ReadAll(c.Request.Body) if err != nil { - http.Error(w, "Invalid JSON", http.StatusBadRequest) + c.AbortWithError(http.StatusBadRequest, fmt.Errorf("Invalid JSON")) return } var requestBody map[string]interface{} if err := json.Unmarshal(bodyBytes, &requestBody); err != nil { - http.Error(w, "Invalid JSON", http.StatusBadRequest) + c.AbortWithError(http.StatusBadRequest, fmt.Errorf("Invalid JSON")) return } model, ok := requestBody["model"].(string) if !ok { - http.Error(w, "Missing or invalid 'model' key", http.StatusBadRequest) + c.AbortWithError(http.StatusBadRequest, fmt.Errorf("Missing or invalid 'model' key")) return } if err := pm.swapModel(model); err != nil { - http.Error(w, fmt.Sprintf("unable to swap to model, %s", err.Error()), http.StatusNotFound) + c.AbortWithError(http.StatusNotFound, fmt.Errorf("unable to swap to model, %s", err.Error())) return } - r.Body = io.NopCloser(bytes.NewBuffer(bodyBytes)) - pm.currentProcess.ProxyRequest(w, r) + c.Request.Body = io.NopCloser(bytes.NewBuffer(bodyBytes)) + pm.currentProcess.ProxyRequest(c.Writer, c.Request) +} + +func (pm *ProxyManager) proxyRequestHandler(c *gin.Context) { + if pm.currentProcess != nil { + pm.currentProcess.ProxyRequest(c.Writer, c.Request) + } else { + c.AbortWithError(http.StatusBadRequest, fmt.Errorf("no strategy to handle request")) + } }