Some side tracking fixing undefined behaviour and memory vulnurabilities

Improve logging output

Reviewed-on: #9

.vscode/settings.json

@@ -85,5 +85,5 @@
   },
   "clang-tidy.buildPath": "builddir/",
   "clangd.onConfigChanged": "restart",
-  "C_Cpp.default.compileCommands": "builddir/compile_commands.json"
+  "C_Cpp.default.compileCommands": "/home/moritz/Projekte/ptouch-prnt/builddir/compile_commands.json"
 }

meson.build

@@ -1,7 +1,7 @@
 project('ptprnt', 'cpp',
     version: 'v0.1.0-'+run_command('git', 'rev-parse',  '--short', 'HEAD', check: true).stdout().strip(),
     license: 'GPLv3',
-    default_options : ['c_std=c11', 'cpp_std=c++17']    
+    default_options : ['c_std=c11', 'cpp_std=c++17', 'b_sanitize=address,undefined', 'b_lto=true', 'b_lto_mode=thin', 'b_thinlto_cache=true']    
 )
 
 usb_dep = dependency('libusb-1.0')

src/P700Printer.cpp

@@ -30,7 +30,7 @@
 #include <vector>
 
 #include "graphics/Bitmap.hpp"
-#include "graphics/Image.hpp"
+#include "graphics/Label.hpp"
 #include "graphics/Monochrome.hpp"
 #include "libusb.h"
 #include "libusbwrap/LibUsbTypes.hpp"
@@ -124,7 +124,7 @@ bool P700Printer::detachUsbDevice() {
 bool P700Printer::printBitmap(const graphics::Bitmap<graphics::ALPHA8>& bitmap) {
     auto bm = graphics::Bitmap<graphics::ALPHA8>(512, 128);
     {
-        auto img = graphics::Image();
+        auto img = graphics::Label();
         bm.setPixels(std::vector<uint8_t>(img.getRaw(), img.getRaw() + 512 * 128));
     }
 
@@ -182,7 +182,7 @@ bool P700Printer::send(std::vector<uint8_t>& data) {
     }
 #else
     tx = data.size();
-    spdlog::debug("USB raw data(len {}): {}", data.size(), spdlog::to_hex(data));
+    SPDLOG_DEBUG("USB raw data(len {}): {}", data.size(), spdlog::to_hex(data));
 #endif
 
     if (tx != static_cast<int>(data.size())) {

src/PtouchPrint.cpp

@@ -39,6 +39,7 @@
 #include "CLI/Option.hpp"
 #include "P700Printer.hpp"
 #include "graphics/Bitmap.hpp"
+#include "graphics/Label.hpp"
 #include "libusbwrap/UsbDeviceFactory.hpp"
 
 namespace ptprnt {
@@ -58,7 +59,7 @@ int PtouchPrint::init(int argc, char** argv) {
     if (mVerboseFlag) {
         setupLogger(spdlog::level::debug);
     } else {
-        setupLogger(spdlog::level::err);
+        setupLogger(spdlog::level::warn);
     }
 
     if (!mUsbDeviceFactory.init()) {
@@ -70,7 +71,7 @@ int PtouchPrint::init(int argc, char** argv) {
 }
 
 int PtouchPrint::run() {
-    spdlog::debug("ptprnt version {}", mVersionString);
+    SPDLOG_DEBUG("ptprnt version {}", mVersionString);
     SPDLOG_TRACE("testing trace");
     auto numFoundPrinters = getCompatiblePrinters();
     if (numFoundPrinters == 0) {
@@ -89,15 +90,24 @@ int PtouchPrint::run() {
             "Found more than one device of the same printer on bus. Currently not supported");
         return -1;
     }
-    printer->attachUsbDevice(devices[0]);
+    printer->attachUsbDevice(std::move(devices[0]));
     auto status = printer->getPrinterStatus();
     spdlog::info("Detected tape width is {}mm", status.tapeWidthMm);
     auto bm = ptprnt::graphics::Bitmap<ptprnt::graphics::ALPHA8>(512, 128);
     //printer->printBitmap(bm);
     //printer->printText("wurst", 1);
 
+    if (0 == mCommands.size()) {
+        spdlog::warn("No command specified, nothing to do...");
+        return 0;
+    }
+
     for (auto& cmd : mCommands) {
-        spdlog::debug("Command: {}", cmd.second);
+        SPDLOG_DEBUG("Command: {}", cmd.second);
+        if (cmd.first == CliCmdType::Text) {
+            auto label{graphics::Label()};
+            label.createLabel(cmd.second);
+        }
     }
 
     return 0;
@@ -106,10 +116,10 @@ int PtouchPrint::run() {
 unsigned int PtouchPrint::getCompatiblePrinters() {
     auto usbDevs = mUsbDeviceFactory.findAllDevices();
 
-    for (auto usbDev : usbDevs) {
+    for (auto& usbDev : usbDevs) {
         auto foundPrinterIt =
             std::find_if(mCompatiblePrinters.begin(), mCompatiblePrinters.end(),
-                         [usbDev](const std::shared_ptr<ptprnt::IPrinterDriver>& printer) {
+                         [&usbDev](const std::shared_ptr<ptprnt::IPrinterDriver>& printer) {
                              return printer->getPid() == usbDev->getPid() &&
                                     printer->getVid() == usbDev->getVid();
                          });
@@ -128,7 +138,12 @@ unsigned int PtouchPrint::getCompatiblePrinters() {
 void PtouchPrint::setupLogger(spdlog::level::level_enum lvl) {
     auto consoleSink = std::make_shared<spdlog::sinks::stdout_color_sink_mt>();
     consoleSink->set_level(lvl);
+    if (spdlog::level::level_enum::debug == lvl || spdlog::level::level_enum::trace == lvl) {
+        // This will enable file and line number for debug and trace macros
+        consoleSink->set_pattern("%^%L:%$ %v (%s:%#)");
+    } else {
         consoleSink->set_pattern("%^%L:%$ %v");
+    }
 
     auto fileSink = std::make_shared<spdlog::sinks::basic_file_sink_mt>("ptprnt.log", true);
     fileSink->set_level(spdlog::level::trace);

src/graphics/Image.cpp

@@ -1,57 +0,0 @@
-/* 
-    ptrnt - print labels on linux
-    Copyright (C) 2023  Moritz Martinius
-
-    This program is free software: you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation, either version 3 of the License, or
-    (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-
-    You should have received a copy of the GNU General Public License
-    along with this program.  If not, see <https://www.gnu.org/licenses/>.
-
- */
-
-#include "Image.hpp"
-
-#include <string>
-
-#include "pango/pango-font.h"
-
-namespace ptprnt::graphics {
-Image::Image() {
-    mSurface         = cairo_image_surface_create(CAIRO_FORMAT_A8, 512, 128);
-    cairo_t* cr      = cairo_create(mSurface);
-    mFontDescription = pango_font_description_new();
-    pango_font_description_set_family(mFontDescription, "sans");
-    pango_font_description_set_weight(mFontDescription, PANGO_WEIGHT_SEMIBOLD);
-    pango_font_description_set_size(mFontDescription, 60 * PANGO_SCALE);
-
-    std::string printThis("Mist 💩");
-
-    mLayout = pango_cairo_create_layout(cr);
-    pango_layout_set_font_description(mLayout, mFontDescription);
-    pango_layout_set_text(mLayout, printThis.c_str(), -1);
-
-    cairo_set_source_rgb(cr, 0.0, 0.0, 0.0);
-    cairo_move_to(cr, 0.0, 94.0);
-    pango_cairo_show_layout_line(cr, pango_layout_get_line(mLayout, 0));
-
-    cairo_surface_write_to_png(mSurface, "hello.png");
-}
-
-uint8_t* Image::getRaw() {
-    cairo_surface_flush(mSurface);
-    return cairo_image_surface_get_data(mSurface);
-}
-
-Image::~Image() {
-    g_object_unref(mLayout);
-    pango_font_description_free(mFontDescription);
-}
-}  // namespace ptprnt::graphics

src/graphics/Label.cpp

@@ -0,0 +1,101 @@
+/* 
+    ptrnt - print labels on linux
+    Copyright (C) 2023  Moritz Martinius
+
+    This program is free software: you can redistribute it and/or modify
+    it under the terms of the GNU General Public License as published by
+    the Free Software Foundation, either version 3 of the License, or
+    (at your option) any later version.
+
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+    GNU General Public License for more details.
+
+    You should have received a copy of the GNU General Public License
+    along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
+ */
+
+#include "graphics/Label.hpp"
+
+#include <algorithm>
+#include <spdlog/spdlog.h>
+
+#include <cstddef>
+#include <iostream>  // remove me
+#include <string>
+
+#include "cairo.h"
+#include "pango/pango-context.h"
+#include "pango/pango-font.h"
+#include "pango/pango-fontmap.h"
+#include "pango/pango-layout.h"
+#include "pango/pango-types.h"
+#include "pango/pangocairo.h"
+
+namespace ptprnt::graphics {
+Label::Label() {
+    /*mSurface         = cairo_image_surface_create(CAIRO_FORMAT_A8, 512, 128);
+    cairo_t* cr      = cairo_create(mSurface);
+    mFontDescription = pango_font_description_new();
+    pango_font_description_set_family(mFontDescription, "sans");
+    pango_font_description_set_weight(mFontDescription, PANGO_WEIGHT_SEMIBOLD);
+    pango_font_description_set_size(mFontDescription, 60 * PANGO_SCALE);
+
+    std::string printThis("Mist 💩");
+
+    mLayout = pango_cairo_create_layout(cr);
+    pango_layout_set_font_description(mLayout, mFontDescription);
+    pango_layout_set_text(mLayout, printThis.c_str(), -1);
+
+    cairo_set_source_rgb(cr, 0.0, 0.0, 0.0);
+    cairo_move_to(cr, 0.0, 94.0);
+    pango_cairo_show_layout_line(cr, pango_layout_get_line(mLayout, 0));
+
+    cairo_surface_write_to_png(mSurface, "hello.png");*/
+}
+
+uint8_t* Label::getRaw() {
+    cairo_surface_flush(mSurface);
+    return cairo_image_surface_get_data(mSurface);
+}
+
+uint8_t Label::getNumLines(std::string_view strv) {
+    return std::count(strv.begin(), strv.end(), '\n');
+}
+
+void Label::createLabel(const std::string& str) {
+
+    // create Pango layout first, to get the render dimensions
+    auto pangoCtx{pango_font_map_create_context(pango_cairo_font_map_get_default())};
+    auto pangoLyt{pango_layout_new(pangoCtx)};
+    auto pangoFontDesc{pango_font_description_from_string("Noto sans 32")};
+
+    pango_layout_set_single_paragraph_mode(pangoLyt, true);
+    pango_layout_set_height(pangoLyt, getNumLines(str) * -1);
+    pango_layout_set_alignment(pangoLyt, PANGO_ALIGN_CENTER);
+    pango_layout_set_font_description(pangoLyt, pangoFontDesc);
+    pango_context_load_font(pangoCtx, pangoFontDesc);
+    pango_layout_set_text(pangoLyt, str.c_str(), static_cast<int>(str.length()));
+
+    int width = 0, height = 0;
+
+    pango_layout_get_size(pangoLyt, &width, &height);
+
+    SPDLOG_DEBUG("Layout width: {}, height: {}", width / PANGO_SCALE, height / PANGO_SCALE);
+
+    auto surf   = cairo_image_surface_create(CAIRO_FORMAT_A8, width / PANGO_SCALE, 128);
+    cairo_t* cr = cairo_create(surf);
+    pango_cairo_show_layout(cr, pangoLyt);
+
+    cairo_set_source_rgb(cr, 0.0, 0.0, 0.0);
+
+    // Debug only
+    cairo_surface_write_to_png(surf, "hellow.png");
+}
+
+Label::~Label() {
+    SPDLOG_DEBUG("Image dtor...");
+}
+}  // namespace ptprnt::graphics

src/graphics/Label.hpp

@@ -22,15 +22,30 @@
 #include <pango/pangocairo.h>
 
 #include <cstdint>
+#include <string>
 
 namespace ptprnt::graphics {
-class Image {
+
+constexpr const char* DEFAULT_FONT_FAMILY = "sans";
+constexpr const uint8_t DEFAULT_FONT_SIZE = 32;
+
+class Label {
    public:
-    Image();
-    ~Image();
+    Label();
+    ~Label();
+
+    Label(const Label&)            = delete;
+    Label& operator=(const Label&) = delete;
+    Label(Label&&)                 = delete;
+    Label& operator=(Label&&)      = delete;
+
     uint8_t* getRaw();
+    void createLabel(const std::string& labelText);
 
    private:
+    // methods
+    uint8_t getNumLines(std::string_view str);
+    // members
     PangoLayout* mLayout;
     PangoFontDescription* mFontDescription;
     cairo_surface_t* mSurface;

src/graphics/Monochrome.cpp

@@ -22,6 +22,7 @@
 #include <cmath>
 
 #include <cstdint>
+#include <iostream>
 #include <vector>
 
 namespace ptprnt::graphics {
@@ -41,9 +42,9 @@ std::vector<uint8_t> Monochrome::get() {
 
     unsigned int outIndex = 0;
 
-    for (unsigned int byteNum = 0; byteNum < mPixels.size(); byteNum += 8) {
-        for (unsigned int bitNo = 0; bitNo < 8; bitNo++) {
-            if (mPixels[byteNum + bitNo] > mThreshhold) {
+    for (unsigned int byteNo = 0; byteNo < mPixels.size(); byteNo += 8) {
+        for (unsigned int bitNo = 0; bitNo <= 7 && (byteNo + bitNo < mPixels.size()); bitNo++) {
+            if (mPixels[byteNo + bitNo] > mThreshhold) {
                 outPixels[outIndex] |= (1 << (7 - bitNo));
             } else {
                 outPixels[outIndex] &= ~(1 << (7 - bitNo));

src/graphics/hello.png

@@ -0,0 +1,6 @@
+{
+  "text" : "Hello, world :)!",
+  "font" : "Liberation Sans",
+  "single-paragraph" : true,
+  "height" : 0
+}

src/graphics/hello.txt

@@ -0,0 +1,7 @@
+{
+  "text" : " Hello",
+  "font" : "FreeSans 32",
+  "single-paragraph" : true,
+  "alignment" : "center",
+  "height" : 0
+}

src/hello.txt

@@ -0,0 +1,7 @@
+{
+  "text" : " Hello",
+  "font" : "FreeSans 32",
+  "single-paragraph" : true,
+  "alignment" : "center",
+  "height" : 0
+}

src/libusbwrap/UsbDevice.cpp

@@ -27,12 +27,13 @@
 #include "libusbwrap/interface/IUsbDevice.hpp"
 
 namespace libusbwrap {
-UsbDevice::UsbDevice(libusb_context* ctx, libusb_device* dev) : mLibusbCtx(ctx), mLibusbDev(dev) {
+UsbDevice::UsbDevice(libusb_context* ctx, usbDevice_ptr dev)
+    : mLibusbCtx(ctx), mLibusbDev(std::move(dev)) {
     if (mLibusbCtx == nullptr || mLibusbDev == nullptr) {
         throw std::invalid_argument("ctx or device are nullptr");
     }
 
-    libusb_get_device_descriptor(dev, &mLibusbDevDesc);
+    libusb_get_device_descriptor(mLibusbDev.get(), &mLibusbDevDesc);
 }
 
 UsbDevice::~UsbDevice() {
@@ -44,7 +45,7 @@ UsbDevice::~UsbDevice() {
 }
 
 bool UsbDevice::open() {
-    int openStatus = libusb_open(mLibusbDev, &mLibusbDevHandle);
+    int openStatus = libusb_open(mLibusbDev.get(), &mLibusbDevHandle);
     if (openStatus != 0) {
         mLastError = static_cast<Error>(openStatus);
         return false;
@@ -113,15 +114,15 @@ const uint16_t UsbDevice::getPid() {
 }
 
 const device::Speed UsbDevice::getSpeed() {
-    return static_cast<device::Speed>(libusb_get_device_speed(mLibusbDev));
+    return static_cast<device::Speed>(libusb_get_device_speed(mLibusbDev.get()));
 }
 
 const uint8_t UsbDevice::getBusNumber() {
-    return libusb_get_bus_number(mLibusbDev);
+    return libusb_get_bus_number(mLibusbDev.get());
 }
 
 const uint8_t UsbDevice::getPortNumber() {
-    return libusb_get_port_number(mLibusbDev);
+    return libusb_get_port_number(mLibusbDev.get());
 }
 
 const Error UsbDevice::getLastError() {

src/libusbwrap/UsbDevice.hpp

@@ -27,14 +27,27 @@
 #include "libusbwrap/interface/IUsbDevice.hpp"
 
 namespace libusbwrap {
+
+struct usbDevice_deleter {
+    void operator()(libusb_device* dev_ptr) const {
+        if (nullptr != dev_ptr) {
+            libusb_unref_device(dev_ptr);
+        }
+    }
+};
+
+using usbDevice_ptr = std::unique_ptr<libusb_device, usbDevice_deleter>;
+
 class UsbDevice : public IUsbDevice {
    public:
-    explicit UsbDevice(libusb_context* ctx, libusb_device* dev);
+    explicit UsbDevice(libusb_context* ctx, usbDevice_ptr dev);
     ~UsbDevice() override;
 
     // delete copy ctor and assignment
     UsbDevice(const UsbDevice&)            = delete;
-    UsbDevice& operator=(UsbDevice&) = delete;
+    UsbDevice& operator=(const UsbDevice&) = delete;
+    UsbDevice(UsbDevice&&)                 = delete;
+    UsbDevice& operator=(UsbDevice&&)      = delete;
 
     bool open() override;
     void close() override;
@@ -59,9 +72,9 @@ class UsbDevice : public IUsbDevice {
 
    private:
     libusb_context* mLibusbCtx{nullptr};
-    libusb_device* mLibusbDev{nullptr};
+    usbDevice_ptr mLibusbDev{nullptr};
     libusb_device_handle* mLibusbDevHandle{nullptr};
-    libusb_device_descriptor mLibusbDevDesc;
+    libusb_device_descriptor mLibusbDevDesc{0};
     std::atomic<bool> mIsOpen = false;
     Error mLastError          = Error::SUCCESS;
 };

src/libusbwrap/UsbDeviceFactory.cpp

@@ -20,9 +20,11 @@
 #include "libusbwrap/UsbDeviceFactory.hpp"
 
 #include <spdlog/spdlog.h>
+#include <sys/types.h>
 
 #include <memory>
 #include <optional>
+#include <vector>
 
 #include "libusb.h"
 #include "libusbwrap/UsbDevice.hpp"
@@ -30,50 +32,53 @@
 
 namespace libusbwrap {
 
-UsbDeviceFactory::~UsbDeviceFactory() {
-    if (mDeviceListInitialized) {
-        libusb_free_device_list(mLibusbDeviceList, 1);
-    }
-}
+UsbDeviceFactory::~UsbDeviceFactory() = default;
 
-std::vector<std::shared_ptr<IUsbDevice>> UsbDeviceFactory::findAllDevices() {
+std::vector<std::unique_ptr<IUsbDevice>> UsbDeviceFactory::findAllDevices() {
     refreshDeviceList();
     return buildMaskedDeviceVector(0x0, 0x0, 0x0, 0x0);
 }
 
-std::vector<std::shared_ptr<IUsbDevice>> UsbDeviceFactory::findDevices(uint16_t vid, uint16_t pid) {
+std::vector<std::unique_ptr<IUsbDevice>> UsbDeviceFactory::findDevices(uint16_t vid, uint16_t pid) {
     refreshDeviceList();
-    return buildMaskedDeviceVector(0xffff, 0xffff, vid, pid);
+    return buildMaskedDeviceVector(LIBUSB_BITMASK_ALL, LIBUSB_BITMASK_ALL, vid, pid);
 }
 
-int UsbDeviceFactory::refreshDeviceList() {
-    int ret = libusb_get_device_list(mLibusbCtx, &mLibusbDeviceList);
+ssize_t UsbDeviceFactory::refreshDeviceList() {
+    libusb_device** list{nullptr};
+
+    ssize_t ret = libusb_get_device_list(mLibusbCtx, &list);
+    mLibusbDeviceList.clear();
     if (ret < 0) {
         spdlog::error("Error enumarating USB devices");
     } else if (ret == 0) {
         spdlog::warn("No USB devices found");
     }
-    mDeviceListInitialized = true;
+
+    for (ssize_t i = 0; i < ret; i++) {
+        mLibusbDeviceList.emplace_back(list[i]);
+    }
+
+    libusb_free_device_list(list, false);
     return ret;
 }
 
-std::vector<std::shared_ptr<IUsbDevice>> UsbDeviceFactory::buildMaskedDeviceVector(uint16_t vidMask,
+std::vector<std::unique_ptr<IUsbDevice>> UsbDeviceFactory::buildMaskedDeviceVector(uint16_t vidMask,
                                                                                    uint16_t pidMask,
                                                                                    uint16_t vid,
                                                                                    uint16_t pid) {
-    std::vector<std::shared_ptr<IUsbDevice>> matchedDevices;
+    std::vector<std::unique_ptr<IUsbDevice>> matchedDevices;
     // see libusb/examples/listdevs.c
-    int i                  = 0;
-    libusb_device* currDev = nullptr;
-    while ((currDev = mLibusbDeviceList[i++]) != nullptr) {
-        struct libusb_device_descriptor currDevDesc;
-        int ret = libusb_get_device_descriptor(currDev, &currDevDesc);
+    for (auto& currDev : mLibusbDeviceList) {
+        struct libusb_device_descriptor currDevDesc {};
+
+        int ret = libusb_get_device_descriptor(currDev.get(), &currDevDesc);
         if (ret < 0) {
             continue;
         }
         if (((currDevDesc.idVendor & vidMask) == vid) &&
             ((currDevDesc.idProduct & pidMask) == pid)) {
-            matchedDevices.push_back(std::make_shared<UsbDevice>(mLibusbCtx, currDev));
+            matchedDevices.push_back(std::make_unique<UsbDevice>(mLibusbCtx, std::move(currDev)));
         }
     }
     return matchedDevices;

src/libusbwrap/UsbDeviceFactory.hpp

@@ -19,9 +19,16 @@
 
 #pragma once
 
+#include <cstdint>
+
+#include "libusb.h"
+#include "libusbwrap/UsbDevice.hpp"
 #include "libusbwrap/interface/IUsbDeviceFactory.hpp"
 
 namespace libusbwrap {
+
+constexpr const uint16_t LIBUSB_BITMASK_ALL = 0xffff;
+
 class UsbDeviceFactory : public IUsbDeviceFactory {
    public:
     UsbDeviceFactory() = default;
@@ -39,7 +46,7 @@ class UsbDeviceFactory : public IUsbDeviceFactory {
      * 
      * @return std::vector<std::shared_ptr<IUsbDevice>> Vector of all detected USB devices
      */
-    std::vector<std::shared_ptr<IUsbDevice>> findAllDevices() override;
+    std::vector<std::unique_ptr<IUsbDevice>> findAllDevices() override;
     /**
      * @brief Gets all devices with certain vid/pid combination. 
      *        If only one device of certain type is connected, vector is usually only one element
@@ -48,17 +55,17 @@ class UsbDeviceFactory : public IUsbDeviceFactory {
      * @param pid ProductId of the devices to find
      * @return std::vector<std::shared_ptr<IUsbDevice>> Vector of detected USB devices based on vid/pid
      */
-    std::vector<std::shared_ptr<IUsbDevice>> findDevices(uint16_t vid, uint16_t pid) override;
+    std::vector<std::unique_ptr<IUsbDevice>> findDevices(uint16_t vid, uint16_t pid) override;
 
    private:
     // methods
-    int refreshDeviceList();
-    std::vector<std::shared_ptr<IUsbDevice>> buildMaskedDeviceVector(uint16_t vidMask,
+    ssize_t refreshDeviceList();
+    std::vector<std::unique_ptr<IUsbDevice>> buildMaskedDeviceVector(uint16_t vidMask,
                                                                      uint16_t pidMask, uint16_t vid,
                                                                      uint16_t pid);
     // members
     libusb_context* mLibusbCtx{nullptr};
-    libusb_device** mLibusbDeviceList{};
+    std::vector<usbDevice_ptr> mLibusbDeviceList{};
     bool mDeviceListInitialized = false;
 };
 }  // namespace libusbwrap

src/libusbwrap/interface/IUsbDeviceFactory.hpp

@@ -10,7 +10,7 @@ namespace libusbwrap {
 class IUsbDeviceFactory {
    public:
     virtual ~IUsbDeviceFactory()                                      = default;
-    virtual std::vector<std::shared_ptr<IUsbDevice>> findAllDevices() = 0;
-    virtual std::vector<std::shared_ptr<IUsbDevice>> findDevices(uint16_t vid, uint16_t pid) = 0;
+    virtual std::vector<std::unique_ptr<IUsbDevice>> findAllDevices() = 0;
+    virtual std::vector<std::unique_ptr<IUsbDevice>> findDevices(uint16_t vid, uint16_t pid) = 0;
 };
 }  // namespace libusbwrap

src/meson.build

@@ -9,14 +9,14 @@ ptprnt_hpps = files (
     'P700Printer.hpp',
     'PtouchPrint.hpp',
     'graphics/Bitmap.hpp',
-    'graphics/Image.hpp',
+    'graphics/Label.hpp',
     'graphics/Monochrome.hpp'
 )
 
 ptprnt_srcs = files (
     'PtouchPrint.cpp',
     'P700Printer.cpp',
-    'graphics/Image.cpp',
+    'graphics/Label.cpp',
     'graphics/Bitmap.cpp',
     'graphics/Monochrome.cpp',
     'libusbwrap/UsbDeviceFactory.cpp',

tests/label_test/label_test.cpp

@@ -17,12 +17,12 @@
 
  */
 
-#include "graphics/Image.hpp"
+#include "graphics/Label.hpp"
 
 #include <gtest/gtest.h>
 
 #include <optional>
 
-TEST(basic_test, Image_smokeTest_succeeds) {
-    auto im = ptprnt::graphics::Image();
+TEST(basic_test, Label_smokeTest_succeeds) {
+    auto im = ptprnt::graphics::Label();
 }

tests/meson.build

@@ -1,5 +1,5 @@
 tests = [['bitmap_test', 'bitmap_test_exe', ptprnt_srcs + ['bitmap_test/bitmap_test.cpp']],
-         ['image_test', 'image_test_exe', ptprnt_srcs +['image_test/image_test.cpp']],
+         ['label_test', 'label_test_exe', ptprnt_srcs +['label_test/label_test.cpp']],
          ['monochrome_test', 'monochrome_test_exe', ptprnt_srcs +['monochrome_test/monochrome_test.cpp']]
         ]