andreas/ComfyUI
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
3,022 Commits 1 Branch 0 Tags
ff838657fac787a0e7aef6bbbf92ea4411bdbd15
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
comfyanonymous ff838657fa Cleaner handling of attention mask in ltxv model code. 2025-01-09 07:12:03 -05:00
comfyanonymous 2307ff6746 Improve some logging messages. 2025-01-08 19:05:22 -05:00
comfyanonymous d0f3752e33 Properly calculate inner dim for t5 model. 
This is required to support some different types of t5 models.
 2025-01-07 17:33:03 -05:00
comfyanonymous 4209edf48d Make a few more samplers deterministic. 2025-01-07 02:12:32 -05:00
comfyanonymous 916d1e14a9 Make ancestral samplers more deterministic. 2025-01-06 03:04:32 -05:00
comfyanonymous c8a3492c22 Make the device an optional parameter in the clip loaders. 2025-01-05 04:29:36 -05:00
comfyanonymous 5cbf79787f Add advanced device option to clip loader nodes. 
Right click the "Load CLIP" or DualCLIPLoader node and "Show Advanced".
 2025-01-05 01:46:11 -05:00
comfyanonymous d45ebb63f6 Remove old unused function. 2025-01-04 07:20:54 -05:00
comfyanonymous 8f29664057 Change defaults in nightly package workflow. 2025-01-03 12:12:17 -05:00
comfyanonymous 9e9c8a1c64 Clear cache as often on AMD as Nvidia. 
I think the issue this was working around has been solved.

If you notice that this change slows things down or causes stutters on
your AMD GPU with ROCm on Linux please report it.
 2025-01-02 08:44:16 -05:00
comfyanonymous 79eea51a1d Fix and enforce all ruff W rules. 2025-01-01 03:08:33 -05:00
comfyanonymous b7572b2f87 Fix and enforce no trailing whitespace. 2024-12-31 03:16:37 -05:00
comfyanonymous d9b7cfac7e Fix and enforce new lines at the end of files. 2024-12-30 04:14:59 -05:00
comfyanonymous a618f768e0 Auto reshape 2d to 3d latent for single image generation on video model. 2024-12-29 02:26:49 -05:00
comfyanonymous e1dec3c792 Fix formatting. 2024-12-28 05:33:17 -05:00
comfyanonymous b504bd606d Add ruff rule for empty line with trailing whitespace. 2024-12-28 05:23:08 -05:00
comfyanonymous d170292594 Remove some trailing white space. 2024-12-27 18:02:30 -05:00
comfyanonymous 4b5bcd8ac4 Closer memory estimation for hunyuan dit model. 2024-12-27 07:37:00 -05:00
comfyanonymous ceb50b2cbf Closer memory estimation for pixart models. 2024-12-27 07:30:09 -05:00
comfyanonymous 160ca08138 Use python 3.9 in launch test instead of 3.8 
Fix ruff check.
 2024-12-26 20:05:54 -05:00
comfyanonymous ee9547ba31 Improve temporal VAE Encode (Tiled) math. 2024-12-26 07:18:49 -05:00
comfyanonymous 19a64d6291 Cleanup some mac related code. 2024-12-25 05:32:51 -05:00
comfyanonymous b486885e08 Disable bfloat16 on older mac. 2024-12-25 05:18:50 -05:00
comfyanonymous 0229228f3f Clean up the VAE dtypes code. 2024-12-25 04:50:34 -05:00
comfyanonymous 1ed75ab30e Update nightly pytorch instructions in readme for nvidia. 2024-12-25 03:29:03 -05:00
comfyanonymous 99a1fb6027 Make fast fp8 take a bit less peak memory. 2024-12-24 18:05:19 -05:00
comfyanonymous 73e04987f7 Prevent black images in VAE Decode (Tiled) node. 
Overlap should be minimum 1 with tiling 2 for tiled temporal VAE decoding.
 2024-12-24 07:36:30 -05:00
comfyanonymous 5388df784a Add temporal tiling to VAE Encode (Tiled) node. 2024-12-24 07:10:09 -05:00
comfyanonymous bc6dac4327 Add temporal tiling to VAE Decode (Tiled) node. 
You can now do tiled VAE decoding on the temporal direction for videos.
 2024-12-23 20:03:37 -05:00
comfyanonymous 15564688ed Add a try except block so if torch version is weird it won't crash. 2024-12-23 03:22:48 -05:00
comfyanonymous e44d0ac7f7 Make --novram completely offload weights. 
This flag is mainly used for testing the weight offloading, it shouldn't
actually be used in practice.

Remove useless import.
 2024-12-23 01:51:08 -05:00
comfyanonymous 56bc64f351 Comment out some useless code. 2024-12-22 23:51:14 -05:00
comfyanonymous 80f07952d2 Fix lowvram issue with ltxv vae. 2024-12-22 23:20:17 -05:00
comfyanonymous 57f330caf9 Relax minimum ratio of weights loaded in memory on nvidia. 
This should make it possible to do higher res images/longer videos by
further offloading weights to CPU memory.

Please report an issue if this slows down things on your system.
 2024-12-22 03:06:37 -05:00
comfyanonymous 601ff9e3db Add that Hunyuan Video and Pixart are supported to readme. 
Clean up the supported models part of the readme.
 2024-12-21 11:31:39 -05:00
comfyanonymous da13b6b827 Get rid of meshgrid warning. 2024-12-20 18:02:12 -05:00
comfyanonymous c86cd58573 Remove useless code. 2024-12-20 17:50:03 -05:00
comfyanonymous b5fe39211a Remove some useless code. 2024-12-20 17:43:50 -05:00
comfyanonymous e946667216 Some fixes/cleanups to pixart code. 
Commented out the masking related code because it is never used in this
implementation.
 2024-12-20 17:10:52 -05:00
comfyanonymous 418eb7062d Support new LTXV VAE. 2024-12-20 04:38:29 -05:00
comfyanonymous cac68ca813 Fix some more video tiled encode issues. 
The downscale_ratio formula for the temporal had issues with some frame
numbers.
 2024-12-19 23:14:03 -05:00
comfyanonymous 52c1d933b2 Fix tiled hunyuan video VAE encode issue. 
Some shapes like 1024x1024 with tile_size 256 and overlap 64 had issues.
 2024-12-19 22:55:15 -05:00
comfyanonymous 2dda7c11a3 More proper fix for the memory issue. 2024-12-19 16:21:56 -05:00
comfyanonymous 3ad3248ad7 Fix lowvram bug when using a model multiple times in a row. 
The memory system would load an extra 64MB each time until either the
model was completely in memory or OOM.
 2024-12-19 16:04:56 -05:00
comfyanonymous c441048a4f Make VAE Encode tiled node work with video VAE. 2024-12-19 05:31:39 -05:00
comfyanonymous 9f4b181ab3 Add fast previews for hunyuan video. 2024-12-18 18:24:23 -05:00
comfyanonymous cbbf077593 Small optimizations. 2024-12-18 18:23:28 -05:00
comfyanonymous ff2ff02168 Support old diffusion-pipe hunyuan video loras. 2024-12-18 06:23:54 -05:00
comfyanonymous 4c5c4ddeda Fix regression in VAE code on old pytorch versions. 2024-12-18 03:08:28 -05:00
comfyanonymous 79badea452 Add ConditioningStableAudio. 
This lets you control the seconds_start and seconds_total parameters for
the Stable Audio model.
 2024-12-18 03:01:12 -05:00
comfyanonymous 37e5390f5f Add: --use-sage-attention to enable SageAttention. 
You need to have the library installed first.
 2024-12-18 01:56:10 -05:00
comfyanonymous a4f59bc65e Pick attention implementation based on device in llama code. 2024-12-18 01:30:20 -05:00
comfyanonymous ca457f7ba1 Properly tokenize the template for hunyuan video. 2024-12-17 16:22:02 -05:00
comfyanonymous cd6f615038 Fix tiled vae not working with some shapes. 2024-12-17 16:22:02 -05:00
comfyanonymous e4e1bff605 Support diffusion-pipe hunyuan video lora format. 2024-12-17 07:14:21 -05:00
comfyanonymous d6656b0c0c Support llama hunyuan video text encoder in scaled fp8 format. 2024-12-17 04:19:22 -05:00
comfyanonymous f4cdedea62 Fix regression with ltxv VAE. 2024-12-17 02:17:31 -05:00
comfyanonymous 39b1fc4ccc Adjust used dtypes for hunyuan video VAE and diffusion model. 2024-12-16 23:31:10 -05:00
comfyanonymous 0b25f47bd9 Add some missing imports. 2024-12-16 19:42:01 -05:00
comfyanonymous bda1482a27 Basic Hunyuan Video model support. 2024-12-16 19:35:40 -05:00
comfyanonymous 19ee5d9d8b Don't expand mask when not necessary. 
Expanding seems to slow down inference.
 2024-12-16 18:22:50 -05:00
comfyanonymous 6d1a3f7d00 Fix case of ExecutionBlocker not handled correctly with INPUT_IS_LIST. 2024-12-15 08:41:35 -05:00
comfyanonymous e83063bf24 Support conv3d in PatchEmbed. 2024-12-14 05:46:04 -05:00
comfyanonymous 4e14032c02 Make pad_to_patch_size function work on multi dim. 2024-12-13 07:22:05 -05:00
comfyanonymous fd5dfb812c Set initial load devices for te and model to mps device on mac. 2024-12-12 06:00:31 -05:00
comfyanonymous 7a7efe8424 Support loading some checkpoint files with nested dicts. 2024-12-11 08:04:54 -05:00
comfyanonymous 44db978531 Fix a few things in text enc code for models with no eos token. 2024-12-10 23:07:26 -05:00
comfyanonymous 1c8d11e48a Support different types of tokenizers. 
Support tokenizers without an eos token.

Pass full sentences to tokenizer for more efficient tokenizing.
 2024-12-10 15:03:39 -05:00
comfyanonymous e2fafe0686 Make CLIP set last layer node work with t5 models. 2024-12-09 03:57:14 -05:00
comfyanonymous 6579632201 Remove unused imports and variables. 2024-12-08 08:08:12 -05:00
comfyanonymous ac2f0523ca Set env vars to disable telemetry in libs used by some custom nodes. 2024-12-07 14:51:45 -05:00
comfyanonymous 8af9a91e0c A few improvements to #5937. 2024-12-06 05:49:15 -05:00
comfyanonymous 1e21f4c14e Make timestep ranges more usable on rectified flow models. 
This breaks some old workflows but should make the nodes actually useful.
 2024-12-05 16:40:58 -05:00
comfyanonymous 9a616b81c1 Add rescaling_scale from STG to SkipLayerGuidanceDiT. 2024-12-04 19:25:50 -05:00
comfyanonymous 3bed56bb13 Add another ROCm tip. 2024-12-04 15:14:12 -05:00
comfyanonymous 452179fe4f Make ModelPatcher class clone function work with inheritance. 2024-12-03 13:57:57 -05:00
comfyanonymous c1b92b719d Some optimizations to euler a. 2024-12-03 06:11:52 -05:00
comfyanonymous 57e8bf6a9f Fix case where a memory leak could cause crash. 
Now the only symptom of code messing up and keeping references to a model
object when it should not will be endless prints in the log instead of the
next workflow crashing ComfyUI.
 2024-12-02 19:49:49 -05:00
comfyanonymous 2d5b3e0078 Remove useless code. 2024-12-02 06:49:55 -05:00
comfyanonymous 8e4118c0de make dpm_2_ancestral work with rectified flow. 2024-12-01 07:37:41 -05:00
comfyanonymous 3fc6ebcdd7 Add basic style model "multiply" strength. 2024-11-30 07:27:11 -05:00
comfyanonymous 20a560eb97 How to enable experimental memory efficient attention on ROCm RDNA3. 2024-11-29 06:19:49 -05:00
comfyanonymous 26fb2c68e8 Add a way to disable cropping in the CLIPVisionEncode node. 2024-11-28 20:24:47 -05:00
comfyanonymous bf2650a80e Fast previews for ltxv. 2024-11-28 06:46:15 -05:00
comfyanonymous b666539595 Remove print. 2024-11-27 20:28:39 -05:00
comfyanonymous 95d8713482 Missing parentheses. 2024-11-27 13:45:32 -05:00
comfyanonymous 0d4e29f13f LTXV model merging node. 2024-11-27 01:43:31 -05:00
comfyanonymous 497db6212f Alternative fix for #5767 2024-11-26 17:53:04 -05:00
comfyanonymous 4c82741b54 Support official SD3.5 Controlnets. 2024-11-26 11:31:25 -05:00
comfyanonymous 15c39ea757 Support for the official mochi lora format. 2024-11-26 03:34:36 -05:00
comfyanonymous b7143b74ce Flux inpaint model does not work in fp16. 2024-11-26 01:33:01 -05:00
comfyanonymous 61196d8857 Add option to inference the diffusion model in fp32 and fp64. 2024-11-25 05:00:23 -05:00
comfyanonymous b4526d3fc3 Skip layer guidance now works on hydit model. 2024-11-24 05:54:30 -05:00
comfyanonymous ab885b33ba Skip layer guidance node now works on LTX-Video. 2024-11-23 10:33:05 -05:00
comfyanonymous 839ed3368e Some improvements to the lowvram unloading. 2024-11-22 20:59:15 -05:00
comfyanonymous 6e8cdcd3cb Fix some tiled VAE decoding issues with LTX-Video. 2024-11-22 18:00:34 -05:00
comfyanonymous e5c3f4b87f LTXV lowvram fixes. 2024-11-22 17:17:11 -05:00
comfyanonymous bc6be6c11e Some fixes to the lowvram system. 2024-11-22 16:40:04 -05:00
comfyanonymous 94323a26a7 Remove prints. 2024-11-22 10:51:31 -05:00
comfyanonymous 5818f6cf51 Remove print. 2024-11-22 10:49:15 -05:00