moritz/ptouch-prnt
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Projects Releases Wiki Activity

Fix Logger and other build issues #7

Merged
moritz merged 2 commits from fix-logger into master 2023-11-16 20:26:23 +00:00
Conversation 1 Commits 2 Files Changed 9 +101 -45
moritz commented 2023-11-16 20:24:22 +00:00
Owner
Copy Link

This branch fixes a couple of issues with the build

  • stop linking everything in a library which is then linked against a single main. It doesn't work the way I wanted. If functionality needs to be exposed by a library, it can be done later or with a separate target
  • This should also fix spdlog
  • Source files are now in a separate meson file using mesons files() feautre
  • Improve coverage generation by adding a script generating html coverage reports. This will hopefully keep the motivation higher to create more unit tests
  • Increase the code coverage a bit to demonstrate that statement above is not a fluke 😄
This branch fixes a couple of issues with the build - stop linking everything in a library which is then linked against a single main. It doesn't work the way I wanted. If functionality needs to be exposed by a library, it can be done later or with a separate target - This should also fix spdlog - Source files are now in a separate meson file using mesons files() feautre - Improve coverage generation by adding a script generating html coverage reports. This will hopefully keep the motivation higher to create more unit tests - Increase the code coverage a bit to demonstrate that statement above is not a fluke 😄
moritz added 2 commits 2023-11-16 20:24:22 +00:00
Fix build, logging and added some coverage report (I should do more commits)
All checks were successful
Build ptprnt / build (push) Successful in 1m50s
Details
a08f6167b3
Increase the coverage a bit to see if reporting is motivating :)
All checks were successful
Build ptprnt / build (push) Successful in 1m50s
Details
3fd6671048
moritz reviewed 2023-11-16 20:25:56 +00:00
moritz left a comment
Author
Owner
Copy Link

image
current coverage

![image](/attachments/ed6b6170-99a2-4ed2-922b-a023d6b746c3) current coverage
image.png
102 KiB
moritz merged commit cd15930e1d into master 2023-11-16 20:26:23 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
moritz
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: moritz/ptouch-prnt#7
No description provided.
Delete Branch "fix-logger"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?