4 Commits

Author SHA1 Message Date
d84fcb861a Attempt to setup gitea build action
Some checks failed
Build ptprnt / build (push) Failing after 6s
2023-09-25 18:52:54 +02:00
ccea502734 Explicitly set copy & move constructors to default for Printer 2023-09-25 18:27:02 +02:00
68283a6295 Add Clang-Tidy file 2023-09-24 18:41:33 +02:00
91c12e0ab9 Some cleanup in Bitmap.cpp 2023-09-24 18:20:34 +02:00
5 changed files with 58 additions and 7 deletions

35
.clang-tidy Normal file
View File

@@ -0,0 +1,35 @@
---
Checks: "clang-diagnostic-*,clang-analyzer-*,cppcoreguidelines-*,modernize-*,-modernize-use-trailing-return-type"
WarningsAsErrors: true
HeaderFilterRegex: ""
AnalyzeTemporaryDtors: false
FormatStyle: google
CheckOptions:
- key: cert-dcl16-c.NewSuffixes
value: "L;LL;LU;LLU"
- key: cert-oop54-cpp.WarnOnlyIfThisHasSuspiciousField
value: "0"
- key: cppcoreguidelines-explicit-virtual-functions.IgnoreDestructors
value: "1"
- key: cppcoreguidelines-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic
value: "1"
- key: google-readability-braces-around-statements.ShortStatementLines
value: "1"
- key: google-readability-function-size.StatementThreshold
value: "800"
- key: google-readability-namespace-comments.ShortNamespaceLines
value: "10"
- key: google-readability-namespace-comments.SpacesBeforeComments
value: "2"
- key: modernize-loop-convert.MaxCopySize
value: "16"
- key: modernize-loop-convert.MinConfidence
value: reasonable
- key: modernize-loop-convert.NamingStyle
value: CamelCase
- key: modernize-pass-by-value.IncludeStyle
value: llvm
- key: modernize-replace-auto-ptr.IncludeStyle
value: llvm
- key: modernize-use-nullptr.NullMacros
value: "NULL"

View File

@@ -0,0 +1,18 @@
name: Build ptprnt
on: [push]
jobs:
build:
runs-on: ubuntu-latest
steps:
- run: echo "Branch ${{ gitea.ref }} will be built for project ${{ gitea.repository }}."
- name: Checkout branch
uses: actions/checkout@v3
- name: install meson
run: apt install meson
- name: Install build dependencies
run: apt install libusb-dev libspdlog-dev libpango1.0-dev libcairo2-dev gcovr
- name: setup builddir
run: meson setup builddir -Db_coverage=true
- name: build all targets
run: ninja -C builddir

View File

@@ -41,8 +41,6 @@
namespace ptprnt::printer {
P700Printer::P700Printer() {}
P700Printer::~P700Printer() {
detachUsbDevice();
if (mUsbHndl) {

View File

@@ -33,12 +33,14 @@ namespace ptprnt::printer {
class P700Printer : public ::ptprnt::IPrinterDriver {
public:
P700Printer();
P700Printer() = default;
~P700Printer();
// delete copy ctor and assignment
P700Printer(const P700Printer&) = delete;
P700Printer& operator=(P700Printer&) = delete;
P700Printer(const P700Printer&) = default;
P700Printer& operator=(const P700Printer&) = default;
P700Printer(P700Printer&&) = default;
P700Printer& operator=(P700Printer&&) = default;
// IPrinterDriver
const std::string_view getDriverName() override;

View File

@@ -76,8 +76,6 @@ std::optional<std::vector<T>> Bitmap<T>::getCol(uint16_t col) {
auto it = std::next(mPixels.begin(), col);
for (auto& colElement : colPixels) {
int offset = std::distance(mPixels.begin(), it);
//spdlog::debug("Distance {}: {}", offset, *it);
colElement = *it;
std::advance(it, mWidth);
}